Friendly ping @DanielEScherzer @nielsdos as you participated on the issue 🙂

I'll play with this tomorrow or so. Note that this is fixing long standing behaviour, so targeting 8.5/master is likely more appropriate.

^ what @nielsdos said about not targeting 8.3, but wearing my release manager hat I don't think 8.5 is appropriate

<?php
$test_file = __DIR__ . "/file_skip_empty_lines.tmp";

$test_data = "\r";
file_put_contents($test_file, $test_data);
$lines = file($test_file, FILE_SKIP_EMPTY_LINES);
var_dump($lines);

$test_data = "\r\r";
file_put_contents($test_file, $test_data);
$lines = file($test_file, FILE_SKIP_EMPTY_LINES);
var_dump($lines);

produces:

array(1) {
  [0]=>
" string(1) "
}
array(0) {
}

which seems incorrect to me. Can you explain whether this is the desired behaviour?

@ndossche I addressed your concern and updated the test file as well. Also, I rebased on master as suggested.

This still acts in a way I don't expect:

$test_data = "\r\r\n\n";
file_put_contents($test_file, $test_data);
$lines = file($test_file, FILE_SKIP_EMPTY_LINES);
var_dump($lines);

There are only empty lines in this test file, so the output should be an empty array. Am I misunderstanding something? Admittingly it's been a while since I looked at this.

I took over the PR again, it fixes cases mentioned in the review while being lighter.

@ndossche I added your latest test case to ext/standard/tests/file/file_skip_empty_lines.phpt as well